Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A arachni
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 125
    • Issues 125
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Arachni - Web Application Security Scanner Framework
  • arachni
  • Merge requests
  • !679

Fix user-supplied email addresses containing '+' character.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/seanhandley/fix_autologin_doc into master Feb 26, 2016
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: seanhandley

Autologin plugin fails if the user's email address (quite validly) contains a "+".

Using GMail labels of the form my.user+label@gmail.com I found a scenario where Arachni can't log into the app. On checking the server logs, I saw it was submitting email addresses of the form

my.user label@gmail.com

resulting in the server to return 422 Unprocessable Entity

This is down to the way the form parameters are sanitised in https://github.com/Arachni/arachni/blob/master/lib/arachni/element/form.rb#L423

e.g.

URI.decode_www_form_component "sean.handley+testing@gmail.com"
=> "sean.handley testing@gmail.com"
URI.decode_www_form_component "user[email]=sean.handley+testing@gmail.com"
=> "user[email]=sean.handley testing@gmail.com"
URI.decode "user[email]=sean.handley+testing@gmail.com"
=> "user[email]=sean.handley+testing@gmail.com"
URI.decode_www_form_component "user%5Bemail%5D=sean.handley%2Barachni%40datacentred.co.uk"
=> "user[email]=sean.handley+arachni@datacentred.co.uk"
URI.decode "user%5Bemail%5D=sean.handley%2Barachni%40datacentred.co.uk"
=> "user[email]=sean.handley+arachni@datacentred.co.uk"

An alternative approach is to instruct the user in the plugin documentation to enter the string in an encoded form at https://github.com/arachni/arachni/blob/master/components/plugins/autologin.rb#L110

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/seanhandley/fix_autologin_doc