Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B Bolts-ObjC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 34
    • Issues 34
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • BoltsFramework
  • Bolts-ObjC
  • Merge requests
  • !162

Added nullability annotations to Bolts Tasks.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nikita Lutsenko requested to merge nlutsenko.nullability into master Sep 28, 2015
  • Overview 3
  • Commits 5
  • Pipelines 0
  • Changes 7

Closes #161 (closed)

This pull request adds nullability annotations to Bolts Tasks. Few highlights:

  • This is somewhat potentially breaking, since there are no more implicitly unwrapped optionals in Swift after this is done
  • This will work on any Xcode 6.3.1+ (which is going to be a requirement after this is merged in) (I can make it support versions before, but it will get way more polluted, and not sure on the actual impact)
  • For qualifiers - this is still using __nullable instead of _Nullable, since the latter is available on Xcode 7.0+ only

Everything is split into separate commits for easier review, will squash later.

cc @grantland @hallucinogen

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nlutsenko.nullability