Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B Bolts-ObjC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 34
    • Issues 34
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • BoltsFramework
  • Bolts-ObjC
  • Merge requests
  • !57

Avoid unnecessary call to ‘continueWithBlock:’ when a task is completed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/BrunoBerisso/master into master Aug 27, 2014
  • Overview 11
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: BrunoBerisso

When a continuation block is executed with a BFExecutor the internal block that makes the actual call check if the continuation block returns a BFTask, if that is the case a call to continueWithBlock: is made and the completion source is updated accordingly to the result of the task.

This pull request add code to check if the returned task is complete and update the completion source without made an extra call to continueWithBlock:. This increase the performance on memory consumption and execution time. And also make sence :)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/BrunoBerisso/master