Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B Bolts-ObjC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 34
    • Issues 34
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • BoltsFramework
  • Bolts-ObjC
  • Merge requests
  • !74
An error occurred while fetching the assigned milestone of the selected merge_request.

Tasks list as result for completionOfAllTasks api.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/OdNairy/master into master 10 years ago
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: OdNairy

We had a nil result from completionOfAllTasks for the all time. It will be very helpful to have tasks list in next "bolt". We can found the same idea on the Facebook's Parse.Promise and PromiseKit as well.

P.S. New functionality test have been added and CLA have been signed.

Compare
  • master (base)

and
  • latest version
    22bacd6a
    2 commits, 2 years ago

2 files
+ 25
- 1

    Preferences

    File browser
    Compare changes
Bolts/‎Common‎
BFTa‎sk.m‎ +1 -1
Bolts‎Tests‎
TaskT‎ests.m‎ +24 -0
Bolts/Common/BFTask.m
+ 1
- 1
  • View file @ 22bacd6a


@@ -122,7 +122,7 @@ __attribute__ ((noinline)) void warnBlockingOperationOnMainThread() {
tcs.error = error;
}
} else {
tcs.result = nil;
tcs.result = tasks;
}
}
return nil;
BoltsTests/TaskTests.m
+ 24
- 0
  • View file @ 22bacd6a


@@ -235,6 +235,30 @@
XCTAssertTrue(task.isCancelled);
}
- (void)testTaskForCompletionOfAllTasksResult {
NSMutableArray *tasks = [NSMutableArray array];
const int kTaskCount = 20;
for (int i = 0; i < kTaskCount; ++i) {
double sleepTimeInMs = rand() % 100;
[tasks addObject:[[BFTask taskWithDelay:sleepTimeInMs] continueWithBlock:^id(BFTask *task) {
return @(i);
}]];
}
[[[BFTask taskForCompletionOfAllTasks:tasks] continueWithBlock:^id(BFTask *task) {
XCTAssertEqual(task.result, tasks);
XCTAssertNil(task.error);
XCTAssertNil(task.exception);
XCTAssertFalse(task.isCancelled);
for (int i = 0; i < kTaskCount; ++i) {
XCTAssertEqual(i, [((BFTask *)[task result][i]).result intValue]);
}
return nil;
}] waitUntilFinished];
}
- (void)testTaskForCompletionOfAllTasksSuccess {
NSMutableArray *tasks = [NSMutableArray array];
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/OdNairy/master

Menu

Explore Projects Groups Snippets