Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A Android-IMSI-Catcher-Detector
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 162
    • Issues 162
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CellularPrivacy
  • Android-IMSI-Catcher-Detector
  • Merge requests
  • !281

quit() method found to be not needed, as the issue lied in onDestroy()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/d-mariano/master into master Jan 15, 2015
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: d-mariano

In onDestroy() of AIMSICD.java, when getting the boolean for the persistent service preference by using getBoolean(), the default value is now specified as "false". Earlier, the value was set to "true" and was the reason that the app was not quitting as it should have been doing. I have now discovered that this alone has resolved the issue, and not my initial commit. My initial commit, consisting of finishing the app after launching the main activity via an intent with the flag FLAG_ACTIVITY_CLEAR_TOP set, did not actually make a difference it seems. And so, after testing the removal of the current quit() method I have created in AIMSICD.java, where I have included the launching of this intent with said flag, I find that it has made no difference. As mentioned in #246 (closed), it was recommended to look into the settings.xml file, but I think what was meant to be said was to look at preferences.xml. When looking into the preferences, the pref_persistservice_service key has a default value of "false". This is as it should be. As said before, in the onDestroy() method in AIMSICD.java, when getting a preference, we must specify a value to use in the event the preference is not found. This vlaue should be the same as the default value we want for the preference, and now it is. I hope this clarifies the issue.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/d-mariano/master