Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A Android-IMSI-Catcher-Detector
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 162
    • Issues 162
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CellularPrivacy
  • Android-IMSI-Catcher-Detector
  • Merge requests
  • !633

Example Code cleanup: DbViewerFragment

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/smarek/class-cleanup-1 into development Nov 14, 2015
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: smarek

Just to get your feedback, I'd like to fix as much of current code as possible with this style.

What I did

  • Removed unused imports
  • Removed unused class-global variables
  • Removed dual view.findViewById call with same view id to search for
  • Handled unchecked type of getSelectedItem() return
  • Handled issue, where getSelectedItem() was called in doInBackground, violating this method should be called only from UI thread
  • Removed unecessary return call
  • Removed unused count variable
  • Avoided NPE on result.close();
  • Formatted both comments and code

Is there any reason, why I shouldn't do this like this, or possible, at all?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/smarek/class-cleanup-1