Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A Android-IMSI-Catcher-Detector
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 162
    • Issues 162
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CellularPrivacy
  • Android-IMSI-Catcher-Detector
  • Merge requests
  • !635
An error occurred while fetching the assigned milestone of the selected merge_request.

Cleaned up SmsDetector.java implementation, related issues #615, #537

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/smarek/class-cleanup-2 into development 9 years ago
  • Overview 21
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: smarek

So, what was done:

  • Removed unused class-global fields
  • Removed, WTF, code new Thread().sleep(500);
  • Rewritten implementation of reading String lines out of buffer, including one more local temporary variable
  • Fixed author javadoc tag
  • Replaced first level of for-loop in checkForSilentSms with foreach
  • Removed pointless calls toString() in context like this DETECTION_PHONENUM_SMS_DATA[2].toString() (where DETECTION_PHONENUM_SMS_DATA is array of Strings) Some encoding sincerely occured on-the-fly, hope you don't mind. #615 (closed) discussion points are imho fixed by this PR #537 pointed out that the problem with performance is in string retrieval/parsing/checking, I agree and we should imho migrate the code over to regexp declarations, and I'm worried we do not now correctly handle situations on border of string stream (where detection would fail because the data are incorrectly splitted by newline character)

Activity

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines.

0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/smarek/class-cleanup-2

Menu

Explore Projects Groups Snippets