Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A Android-IMSI-Catcher-Detector
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 162
    • Issues 162
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CellularPrivacy
  • Android-IMSI-Catcher-Detector
  • Merge requests
  • !823

Check current cell against OCID after download

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/f3ndot/ocid-download-and-recheck-improvements into development Mar 25, 2016
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 8

Created by: f3ndot

Agreements

  • I have reviewed and accepted the guidelines for contributing to this project.
  • I have reviewed and closely followed the Style Guide for this Android app.

Overview

This should fix #558 (closed). I verified the fix in my local area by:

  1. Clearing the OCID database so AIMSICD is in a "vanilla" state and going to an area where I'm connected to a cell tower known to OCID.
  2. Observing that I'm getting a MEDIUM/yellow since I have no entries in OCID database to compare against
  3. Download the BTS data from OCID from the sidebar
  4. Observe that the notification has changed from MEDIUM/yellow to OK/green once the successful download toast displays
Specifically resolved issues:
  • CellTracker#setNotification() now always fires when CellTracker#compareLac(CellLocation) is called since recovering from a dangerous state should update the notification. Aka from MEDIUM to OK
  • RequestTask provides a listener interface for completion callbacks so Helpers#getOpenCellData(...) fires OCID check on success
  • Timeout for OCID download increased from default 10 seconds to 60 seconds, since the OCID API is slow as hell.
  • If OCID API times out, we display that to the user as a special error message.

The listener callback interface is a bit crude, but is better than having RequestTask do too much.


Classification

  • Bugfix (non-breaking change which fixes an existing issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor (restructuring of existing code without changing its external functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

References

See #558 (closed) for feature request. This PR supersedes #793.


Screenshots

N/A

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/f3ndot/ocid-download-and-recheck-improvements