MapFragment.loadEntries: Return null if not attached (!824) · Merge requests · CellularPrivacy / Android-IMSI-Catcher-Detector

Merged Administrator requested to merge github/fork/vanitasvitae/fix_map_fragment_crash into development Mar 29, 2016

Created by: vanitasvitae

Thank you for submitting a pull request! Please add below details so that we can merge it faster.

Agreements

I have reviewed and accepted the guidelines for contributing to this project.
I have reviewed and closely followed the Style Guide for this Android app.

Overview

AIMSICD crashed before when the MapFragment was opened, then another fragment (eg. DatabaseViewer) was opened afterwards and then the app was closed by the user by double tapping the back button. The MapFragment then threw a IllegalStateException.

I added check isAdded() to three points in the code to return null if fragment is not attached to prevent a crash when exiting the app.

Classification

Bugfix (non-breaking change which fixes an existing issue)

References

If your pull request is related to or solves any existing Issues, please link them here.