Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Issues
  • #5160
Closed
Open
Issue created Oct 14, 2021 by Derek Bruening@derekbrueningContributor

Move annotation handling to a client?

For #4128 (closed) we want drreg to know about all clean calls, yet annotation handler clean calls are inserted during mangling and are thus invisible to clients. The solution there for now is for drreg to look for the DR_NOTE_ANNOTATION label that is added in the app2app phase.

We could move just the clean call insertion to a client in the insertion phase, or try to move the annotation insruction sequence identification: but that may be harder to move.

Alternatively, we could collapse drmgr into the core, and then move the handler clean call to the drmgr insertion phase.

EIther approach would eliminate the drreg special-casing of annotation clean calls, and make them visible to instru2instru and other client actions.

Assignee
Assign to
Time tracking