Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3920

i#3911: Change 0 and 0LL into NULL for variable length arguments of syscall().

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hendrik Greving requested to merge i3911-pselect6-null-mask-test-issue into master Nov 01, 2019
  • Overview 23
  • Commits 3
  • Pipelines 0
  • Changes 2

Fixes a 64-bit bug that led to a non-zero pointer on some systems and a subsequent test failure. Using NULL works for both 32-bit and 64-bit.

Additionally:

  • Adds missing implicit registers to clobber list of syscall inline asm.
  • Adds yet another version for pselect6, in inline asm. The test is semantically redundant to the existing NULL pointer test, and would only expose unexpected changes in glibc's syscall() implementation. Added for completeness.
  • Casts every parameter passed to variadic function syscall() into their safe type according to their function definiton.
  • Fixes all types passed in asm volatile statements as well.
  • Makes all parameters named in asm volatile statements.

Fixes #3911 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3911-pselect6-null-mask-test-issue