Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4839

Remove two (now tested) cases of ASSERT_NOT_TESTED for AARCH64

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sotiris Apostolakis requested to merge iX-remove-assert-not-tested into master Apr 04, 2021
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 2

PR #3003 added handling of a signal interrupting the ibl hit path's jump, but the introduced client.cleancallsig test could not test the ibl jump on AArchXX leading to the insertion of an ASSERT_NOT_TESTED() for AARCHXX. Testing on a proprietary app with plain DR (debug build) on AArch64 hit this case without problems. Thus, we can remove the ASSERT_NOT_TESTED() for AARCH64.

The code inserted in PR #4797 was triggered and tested for AARCH64 on a proprietary app so remove the ASSERT_NOT_TESTED() for AARCH64 from there as well.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: iX-remove-assert-not-tested