Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5593

i#5560 drmemtrace refactor: Split counting + i/o code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i5560-memtrace-refactor into master Aug 05, 2022
  • Overview 8
  • Commits 5
  • Pipelines 0
  • Changes 8

Separates out two big pieces of tracer.cpp into their own files: instruction counting into instr_counter.cpp and i/o into output.cpp. Both still have some dependencies on some of the same TLS and globals as the rest of the tracer, but shrinking the tracer.cpp file is still of value, and the interfaces between the files are not huge. Future work could further modularize and isolate.

Adds a namespace, especially important now that we have global symbols shared between files.

Issue: #5560, #4343

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5560-memtrace-refactor