Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5853

i#5841: Remove "T" from tid field in drmemtrace view to make view less confusing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge i5852-drmemtrace-view-tid-column-inconsistent into master Feb 04, 2023
  • Overview 11
  • Commits 12
  • Pipelines 0
  • Changes 7

Created by: lihasgupta

From this discussion, https://github.com/DynamoRIO/dynamorio/pull/5842#discussion_r1096546216

The table currently looks like this:

<--record#-> <--instr#->: <---tid---> <record details>
------------------------------------------------------------
           1           0:    T3256418 <marker: version 4>
           2           0:    T3256418 <marker: filetype 0x240>
           3           0:    T3256418 <marker: cache line size 64>
           4           0:    T3256418 <marker: chunk instruction count 1024>
           5           0:    T3256418 <marker: page size 4096>
           6           0:    T3256418 <marker: timestamp 13312410768080478>
           7           0:    T3256418 <marker: tid 3256418 on core 7>
           8           1:    T3256418 ifetch       3 byte(s) @ 0x00007fc205a61940 48 89 e7             mov    %rsp, %rdi
           9           2:    T3256418 ifetch       5 byte(s) @ 0x00007fc205a61943 e8 b8 0c 00 00       call   $0x00007fc205a62600
          10           2:    T3256418 write        8 byte(s) @ 0x00007fff9a9e3528 by PC 0x00007fc205a61943
          11           3:    T3256418 ifetch       1 byte(s) @ 0x00007fc205a62600 55                   push   %rbp
          12           3:    T3256418 write        8 byte(s) @ 0x00007fff9a9e3520 by PC 0x00007fc205a62600
          13           4:    T3256418 ifetch       3 byte(s) @ 0x00007fc205a62601 48 89 e5             mov    %rsp, %rbp
          14           5:    T3256418 ifetch       2 byte(s) @ 0x00007fc205a62604 41 57                push   %r15
          15           5:    T3256418 write        8 byte(s) @ 0x00007fff9a9e3518 by PC 0x00007fc205a62604
          16           6:    T3256418 ifetch       2 byte(s) @ 0x00007fc205a62606 41 56                push   %r14
          17           6:    T3256418 write        8 byte(s) @ 0x00007fff9a9e3510 by PC 0x00007fc205a62606
          18           7:    T3256418 ifetch       2 byte(s) @ 0x00007fc205a62608 41 55                push   %r13
          19           7:    T3256418 write        8 byte(s) @ 0x00007fff9a9e3508 by PC 0x00007fc205a62608
          20           8:    T3256418 ifetch       2 byte(s) @ 0x00007fc205a6260a 41 54                push   %r12

Here we have a "T" in front of all the tid values but it is unclear what it is. This should be removed since there is no T in the column header any more.

Issue: #5841 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5852-drmemtrace-view-tid-column-inconsistent