Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5862

i#5857: Remove CONSTEXPR define

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge i5857-remove-constexpr-macro into master Feb 09, 2023
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: lihasgupta

Now that we do not support VS2013 and have C++11 everywhere we can remove this in clients/drcachesim/common/utils.h:

/* TODO(i#2924): Remove this and others like it once we stop supporting VS2013. */
#if defined(WINDOWS) && _MSC_VER < 1900
#    define CONSTEXPR const /* 'constexpr' not supported */
#else
#    define CONSTEXPR constexpr
#endif

This PR removes this.

Issue #5857

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5857-remove-constexpr-macro