Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Issues
  • #11029
Closed
Open
Issue created Dec 03, 2021 by Administrator@rootContributor2 of 6 checklist items completed2/6 checklist items

[BUG] combining typeMappings with default can create broken Pojo artefact

Created by: randeepbydesign

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

Consider the following Object definition in a swagger:

"OdbcConnection": {
  "type": "object",
  "properties": {
    "ConnectionString": {
      "type": "string",
      "nullable": true
    },
    "ConnectionTimeout": {
      "type": "integer",
      "format": "int32",
      "default": 15
    }
  },
  "additionalProperties": false
}

We have a pattern where we try to work with longs so I configure my execution to translate all int to long: <typeMappings>integer=Long,int=Long</typeMappings>

This works well, however in the rendered POJO I get a variable declaration for ConnectionTimeout that attempts to assign an int to a long which does not compile:

  public static final String JSON_PROPERTY_CONNECTION_TIMEOUT = "ConnectionTimeout";
  private Long connectionTimeout = 15;

If I manually modify the swagger to use int64 instead of int32 the 'l' character is appended to the default value correctly.

I believe the toDefaultValue method of the AbstractJavaCodegen needs an addition to account for this situation

openapi-generator version
OpenAPI declaration file content or url
Generation Details
Steps to reproduce
Related issues/PRs
Suggest a fix
Assignee
Assign to
Time tracking