Skip to content
GitLab
Closed
Issue created by Administrator@rootContributor3 of 6 checklist items completed3/6 checklist items

[BUG][Java][RestTemplate] Expanded path used for uri tag in metrics instead of path template

Created by: jmaicher

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

Starting with 5.3.1, the expanded path (e.g. /users/42) is used as value for the uri tag in client metrics instead of the path template (e.g. /users/{id}). This breaks our monitoring and generally leads to cardinality problems (especially in prometheus) and the following warning:

Reached the maximum number of URI tags for 'http.client.requests'. Are you using 'uriVariables'?

The regression is caused by this change to the expandPath method. Due to the usage of a new RestTemplate, existing RestTemplateCustomizer are not applied, in this case MetricsRestTemplateCustomizer, which is automatically registered by RestTemplateMetricsConfiguration via HttpClientMetricsAutoConfiguration.

openapi-generator version

Regression in 5.3.1