Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Issues
  • #13384
Closed
Open
Issue created Sep 08, 2022 by Administrator@rootContributor5 of 6 checklist items completed5/6 checklist items

[BUG][csharp-netcore] anyOf/oneOf generates non-compilable code (null-coalescing operator on enum)

Created by: Ikelio

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

AnyOf/OneOf with an enum will generate non-compilable C# code (using null coalescing operator on an enum): For instance with a oneof parameter schema:

"schema": {
  "oneOf": [
	{
	"title": "firstEnum",
	"enum": [
		"one",
		"two"
	  ]
	},
	{
	"title": "secondEnum",
	"type": "integer",
	"enum": [
		"0",
		"1"
	]
	}
  ]
}

Incorrect code:

        /// <summary>
        /// Initializes a new instance of the <see cref="MyOperationAParameter" /> class
        /// with the <see cref="FirstEnum" /> class
        /// </summary>
        /// <param name="actualInstance">An instance of FirstEnum.</param>
        public MyOperationAParameter(FirstEnum actualInstance)
        {
            this.IsNullable = false;
            this.SchemaType= "oneOf";
            this.ActualInstance = actualInstance ?? throw new ArgumentException("Invalid instance found. Must not be null.");
        }

        /// <summary>
        /// Initializes a new instance of the <see cref="MyOperationAParameter" /> class
        /// with the <see cref="SecondEnum" /> class
        /// </summary>
        /// <param name="actualInstance">An instance of SecondEnum.</param>
        public MyOperationAParameter(SecondEnum actualInstance)
        {
            this.IsNullable = false;
            this.SchemaType= "oneOf";
            this.ActualInstance = actualInstance ?? throw new ArgumentException("Invalid instance found. Must not be null.");
        }

Expected output:

        /// <summary>
        /// Initializes a new instance of the <see cref="MyOperationAParameter" /> class
        /// with the <see cref="FirstEnum" /> class
        /// </summary>
        /// <param name="actualInstance">An instance of FirstEnum.</param>
        public MyOperationAParameter(FirstEnum actualInstance)
        {
            this.IsNullable = false;
            this.SchemaType= "oneOf";
            this.ActualInstance = actualInstance;
        }

        /// <summary>
        /// Initializes a new instance of the <see cref="MyOperationAParameter" /> class
        /// with the <see cref="SecondEnum" /> class
        /// </summary>
        /// <param name="actualInstance">An instance of SecondEnum.</param>
        public MyOperationAParameter(SecondEnum actualInstance)
        {
            this.IsNullable = false;
            this.SchemaType= "oneOf";
            this.ActualInstance = actualInstance;
        }
openapi-generator version

6.0.1

OpenAPI declaration file content or url

anyOf/oneOf with an enum. See in Description.

Steps to reproduce

generate csharp-netcore project with any specification file containing similar anyOf/oneOf.

Related issues/PRs
Suggest a fix

I'll reference this in fix PR.

Assignee
Assign to
Time tracking