Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Issues
  • #2663
Closed
Open
Issue created Apr 14, 2019 by Administrator@rootContributor

[BUG] [jaxrs-spec] equals/hashCode methods in POJOs ignore parent variables

Created by: PhilippParis

Description

When using allOf in the yaml OpenAPI 3.0 file the equals and hashCode methods in generated model classes ignore the parent class properties.

openapi-generator version

Tested with version 4.0, 3.3.4, 3.3.3 and current master branch

OpenAPI declaration file content or url

allof.yaml

Command line used for generation

java -jar openapi-generator-cli.jar generate -g jaxrs-spec -i allof.yaml -o gen/

expected result

Adult.java

@Override
  public boolean equals(java.lang.Object o) {
    if (this == o) {
      return true;
    }
    if (o == null || getClass() != o.getClass()) {
      return false;
    }
    Adult adult = (Adult) o;
    return Objects.equals(this.children, adult.children) &&
        super.equals(o);
  }

actual result

Adult.java

@Override
  public boolean equals(java.lang.Object o) {
    if (this == o) {
      return true;
    }
    if (o == null || getClass() != o.getClass()) {
      return false;
    }
    Adult adult = (Adult) o;
    return Objects.equals(children, adult.children);
  }
Suggest a fix

update equals/hashcode implementations in JavaJaxRS/spec/pojo.mustache template to match Java/pojo.mustache

Assignee
Assign to
Time tracking