Skip to content
GitLab
Closed
Issue created by Administrator@rootContributor5 of 6 checklist items completed5/6 checklist items

[BUG][cpp-restsdk] Header includes are incorrect for models

Created by: dan-drl

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

When generating a cpp-restsdk client it fails to compile out the gate, because header includes are wrong. There is an assumption that the class name and the model file header name are the same, which is not always the case. Specifically, when a open api components contains a dot character in its name.

openapi-generator version

4.0.0-SNAPSHOT

OpenAPI declaration file content or url

https://gist.github.com/dan-drl/b14d505d0b8f8af2787c63ea8dde5727

Command line used for generation

java -jar openapi-generator-cli.jar generate -i test.json -g cpp-restsdk -o .\src\Client --model-package Client

Steps to reproduce
  • Download the json from the git gist
  • Run the command provided
  • Try compiling in VS2017 using CMake extension
  • Observe compiler errors

Assessment.h contains:

#include "Assessments_assessment.h"

Which should be

#include "AssessmentsAssessment.h"
Related issues/PRs

Couldn't find one.

Suggest a fix

I am currently working on PR for this. Use model file name instead of class name.