Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Issues
  • #6002
Closed
Open
Issue created Apr 21, 2020 by Administrator@rootContributor

[BUG][typescript-fetch] Name clash between models and operations

Created by: haraldF

Description

Imagine a Model:

    SubscribeRequest:
      type: object
      properties:
        # ...

and an operation called subscribe:

paths:
  /subscriptions:
    post:
      summary: Subscribe
      operationId: subscribe
      parameters:
          # ...
      requestBody:
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/SubscribeRequest'
        required: true

The generated TypeScript operation would import SubscribeRequest but also generate a class called SubscribeRequest in the same file, which leads to a compilation error:

import {
    SubscribeRequest,
    SubscribeRequestFromJSON,
    SubscribeRequestToJSON,
} from '../models';

// ...

// ERROR - SubscribeRequest name already taken
export interface SubscribeRequest {
    // ...
}
openapi-generator version

Today's master (but also happens with latest released version)

Suggest a fix

One "naive" fix would be to simply escape all models that end with Request:

    @Override
    public String toModelName(final String name) {
        String modelName = super.toModelName(name);
        if (modelName.endsWith("Request") && !modelName.startsWith("Model")) {
            modelName = "Model" + modelName;
        }
        return modelName;
    }
Assignee
Assign to
Time tracking