Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Issues
  • #6847
Closed
Open
Issue created Jul 03, 2020 by Administrator@rootContributor3 of 6 checklist items completed3/6 checklist items

[BUG] client_side_validation comment is backwards

Created by: mdavis-xyz

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs? here
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

In the configuration.py file after generating a python client, it says:

# Disable client side validation
self.client_side_validation = True

This makes it seem like client side validation is disabled by default. But it's not.

The comment should be # set to False to disable client side validation, or just # Enable client side validation

openapi-generator version
openapi-generator-cli 5.0.0-SNAPSHOT
  commit : 068ad02
  built  : 2020-07-02T17:04:18Z
  source : https://github.com/openapitools/openapi-generator
  docs   : https://openapi-generator.tech/
Command line used for generation
docker run --rm \
    -v $PWD:/local \
    openapitools/openapi-generator-cli \
    generate \
    -i /local/repo/direct-plant-control.yaml \
    -g python \
    -o /local/out/python \
    --package-name dispatch
Steps to reproduce
Related issues/PRs

@jonashaag added a comment to the PR by @wing328 that introduced this issue here

Suggest a fix

The comment should be # set to False to disable client side validation, or just # Enable client side validation

Assignee
Assign to
Time tracking