Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Issues
  • #8904
Closed
Open
Issue created Mar 05, 2021 by Administrator@rootContributor5 of 5 checklist items completed5/5 checklist items

[BUG][JavaScript] client generator: Reserved words detector is not case-sensitive

Created by: delenius

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
Description

The JS client generator is case-insensitive when it comes to detecting reserved words, while JavaScript itself is not. For example, it complains about 'InstanceOf' as a model name, and renames it to 'ModelInstanceOf'.

openapi-generator version

5.1.0-SNAPSHOT, commit 976b4aa757e989fbaa28f92a721ade39735332e6.

OpenAPI declaration file content or url

See full details in this test repo.

Suggest a fix

The culprit is this line in DefaultCodegen.java:

    protected boolean isReservedWord(String word) {
        return word != null && reservedWords.contains(word.toLowerCase(Locale.ROOT));
    }

Removing .toLowerCase here should fix the problem. I will submit a PR.

Assignee
Assign to
Time tracking