Skip to content
GitLab

[Dart2]: improved error reporting

Merged Administrator requested to merge github/fork/ircecho/error_reporting into master

Created by: ircecho

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09)

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

Fixed catch in ApiClient to properly display exceptions and errors.

Original error is gobbled, overshadowed by exception in catch block.

Unhandled exception:
type '_TypeError' is not a subtype of type 'Exception'
#0      ApiClient._deserialize (file:///.../lib/api_client.dart:226:78)
#1      ApiClient.deserialize (file:///.../lib/api_client.dart:238:12)
...

becomes

type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, Map<String, dynamic>>'
#0      new ArticleRepresentation.fromJson (file:///.../lib/model/article_representation.dart:85:59)
#1      ArticleRepresentation.listFromJson.<anonymous closure> (file:///.../lib/model/article_representation.dart:128:87)
...

Original error is visible properly.