Skip to content
GitLab

Specify templateDir in all sample configs

Merged Administrator requested to merge github/fork/NathanBaulch/config-tidy into master

Created by: NathanBaulch

I noticed that many sample configs don't have templateDir explicitly defined, meaning you have to rebuild the generator binary (quite slow) each time a template change is made. So I went ahead and added this attribute to all configs where missing.

These changes do not result in any generated sample code changes, as expected.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.