Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !10124

[C][Client] Allocate memory for the element of array when the type is number

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ityuhui/yh-number-array into master Aug 10, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: ityuhui

If the type of element of an array is number, e.g.

        "supplementalGroups": {
          "description": "A list of groups applied to the first process run in each container, in addition to the container's primary GID.  If unspecified, no groups will be added to any container.",
          "items": {
            "format": "int64",
            "type": "integer"
          },
          "type": "array"
        },

The current template code of CLibcurl will not allocate memory for the element before adding it to a list:

    list_addElement(supplemental_groupsList , &supplemental_groups_local->valuedouble);

supplemental_groups_local is a local variable, it will be released soon. And then the pointer pointing to supplemental_groups_local->valuedouble will be invalid.

This PR allocates memory for the element:

    double *supplemental_groups_local_value = (double *)calloc(1, sizeof(double));
    if(!supplemental_groups_local_value)
    {
        goto end;
    }
    *supplemental_groups_local_value = supplemental_groups_local->valuedouble;
    list_addElement(supplemental_groupsList , supplemental_groups_local_value);

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the master: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Hi @wing328 @zhemant @michelealbano

Could you please review this PR ? Thanks.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ityuhui/yh-number-array