Skip to content
GitLab

[python] Fixes a breakage while deserializing the read-only attributes

Merged Administrator requested to merge github/fork/CiscoM31/fix/readonly_breakage into master

Created by: vvb

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

https://github.com/OpenAPITools/openapi-generator/pull/9409 added _new_from_openapi_data and updated the code to invoke this method at most places except one. This PR takes care of updating this as well. Deserialization of read-only attributes breaks without this change.

@spacether @wing328

Added a test that validates the fix.

Here is a snapshot of the same test failing when run on master branch codebase, test_failing test_failing_1

Here is a snapshot of the test passing when run against this PR branch, tests_passing