Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !10310

[bugfix][Elm] Fix template when response schema is Map

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/matsubara0507/fix-elm-templates-with-dict into master Sep 02, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: matsubara0507

cc @eriktim

Generate wrong Elm code when response schema is Map (Dict).

e.g. generate from

openapi: 3.0.1
info:
  title: My title
  description: API under test
  version: 1.0.0
servers:
  - url: https://localhost:9999/root
paths:
  /dict1:
    get:
      responses:
        '200':
          description: 'return dictonary'
          content:
            application/json:
              schema:
                type: object
                additionalProperties:
                  type: boolean
  /dict2:
    get:
      responses:
        '200':
          description: 'return Object has dictionary'
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Hoge'
components:
  schemas:
    Hoge:
      type: object
      properties:
        hoge:
          type: object
          additionalProperties:
            type: boolean

to

dict1Get : Api.Request (Dict.Dict String Bool)
dict1Get =
    Api.request
        "GET"
        "/dict1"
        []
        []
        []
        Nothing
        (Json.Decode.dict Api.Data.boolDecoder)

dict2Get : Api.Request Api.Data.Hoge
dict2Get =
    Api.request
        "GET"
        "/dict2"
        []
        []
        []
        Nothing
        Api.Data.hogeDecoder

hogeDecoder : Json.Decode.Decoder Hoge
hogeDecoder =
    Json.Decode.succeed Hoge
        |> maybeDecode "hoge" (Json.Decode.dict Json.Decode.boolboolDecoder) Nothing

but expected

dict1Get : Api.Request (Dict.Dict String Bool)
dict1Get =
    Api.request
        "GET"
        "/dict1"
        []
        []
        []
        Nothing
        (Json.Decode.dict Json.Decode.bool)

dict2Get : Api.Request Api.Data.Hoge
dict2Get =
    Api.request
        "GET"
        "/dict2"
        []
        []
        []
        Nothing
        Api.Data.hogeDecoder

hogeDecoder : Json.Decode.Decoder Hoge
hogeDecoder =
    Json.Decode.succeed Hoge
        |> maybeDecode "hoge" (Json.Decode.dict Json.Decode.bool) Nothing

fix it

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/matsubara0507/fix-elm-templates-with-dict