Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !1035

[JaxRS-Spec] Fixes in generated pom

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jmini/fix_pom_jaxrs_spec into master Sep 14, 2018
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 6

Created by: jmini

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Description of the PR

Several improvements in the generated POM file for the jaxrs-spec generator:

1/ Add build-helper-maven-plugin plugin in the generated pom to declare src/gen/java as sources.

=> Copied from the Jersey Jaxrs generator

The generator already output some content there:

Examples:

  • src/gen/java/ in jaxrs-spec
  • src/gen/java/ in jaxrs-spec-interface
  • src/gen/java/ in jaxrs-spec-interface-response

2/ Jackson as dependency, because the models are using those annotations.

=> Copied from the Jersey Jaxrs generator

3/ Update javax.ws.rs-api to 2.1.1 because the @PATCH annotation (already used in the generated code) is not present in the 2.0 version.

Example Line 95: https://github.com/OpenAPITools/openapi-generator/blob/526e980a69dc9c73829f202ce5780f5b603633c7/samples/server/petstore/jaxrs-spec/src/gen/java/org/openapitools/api/FakeApi.java#L95-L101

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jmini/fix_pom_jaxrs_spec