Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !10512

[typescript-axios] Fix invalid query params usage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/aiven-hh/fix-typescript-axios-query-params into master 3 years ago
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 13

Created by: aiven-hh

Everything from options is already passed to Axios in https://github.com/OpenAPITools/openapi-generator/blob/c2c4ba5b06c2107ad466c20dfee7a8f191a25139/modules/openapi-generator/src/main/resources/typescript-axios/apiInner.mustache#L57 and later in https://github.com/OpenAPITools/openapi-generator/blob/c2c4ba5b06c2107ad466c20dfee7a8f191a25139/modules/openapi-generator/src/main/resources/typescript-axios/common.mustache#L124 so removing options.query from being passed to setSearchParams is fine because Axios can merge query params from path (where setSearchParams result ends up in) and from options (where all othed params end up in). This also fixes the issue that options.query does not actually exists and the correct parameter is options.params which is now typed correctly (changed in https://github.com/OpenAPITools/openapi-generator/pull/10447).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Loading
Loading

Activity


  • Administrator mentioned in merge request !10447 (merged) 3 years ago

    mentioned in merge request !10447 (merged)

  • Administrator changed title from Fix typescript axios query params to [typescript-axios] Fix invalid query params usage 3 years ago

    changed title from Fix typescript axios query params to [typescript-axios] Fix invalid query params usage

  • Administrator closed 3 years ago

    closed

  • William Cheng changed milestone to %5.3.0 3 years ago

    changed milestone to %5.3.0

  • William Cheng added Client: TypeScript Issue: Bug labels 3 years ago

    added Client: TypeScript Issue: Bug labels

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
meta v5
2
meta v5
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: twbs/bootstrap!29560
Source branch: github/fork/aiven-hh/fix-typescript-axios-query-params

Menu

Explore Projects Groups Snippets