Skip to content
GitLab

[Java][RestTemplate] Fix RestTemplate not handling ApiKey in cookie

Merged Administrator requested to merge github/fork/daiwt/master into master

Created by: daiwt

Fix a bug in Java RestTemplate ApiClient.mustache that ApiKey in cookie is not handled.

Code to handle cookieParams when location is "cookie" already exists, which was merged in #4155:

https://github.com/OpenAPITools/openapi-generator/blob/efa032abdb54b376309ae543eb7f3501d03cdc72/modules/openapi-generator/src/main/resources/Java/libraries/resttemplate/auth/ApiKeyAuth.mustache#L58

To test, you can create a security schema such as:

securitySchemes:
  ExampleCookieAuth:
    type: apiKey
    in: cookie
    name: session

This should send a Cookie header to server like Cookie: session=12345

@wing328

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.