Skip to content
GitLab

Kotlin spring server codegen improvements

Merged Administrator requested to merge github/fork/herojan/required-readonly-optional into master

Created by: herojan

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @dr4ke616

Description of the PR

  • Fixes a bug where lists were instantiated with the arrayOf function.
  • If required and readonly, a field should be optional. This is to allow people to do a GET and easily PUT it back with small changes.
  • Use List type for the OpenApi array. This is because kotlin data classes should not use kotlin.Array since arrays are compared by reference rather than structure. Different arrays with the same content should return true but return false.
  • Uses String instead of kotlin.String, Int instead of kotlin.Int, etc for built-in kotlin types.