Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !10745

[java] use IllegalArgumentException instead of RuntimeException

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged William Cheng requested to merge jersey2-exception into 6.0.x 3 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 30
  • use IllegalArgumentException instead of RuntimeException as suggested by code review

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Compare
  • 6.0.x (base)

and
  • latest version
    c36fe58b
    1 commit, 2 years ago

30 files
+ 30
- 30

    Preferences

    File browser
    Compare changes
modules/openapi-ge‎nerator/…/…/…/Java‎
ServerConfigur‎ation.mustache‎ +1 -1
sam‎ples‎
cli‎ent‎
others/java/…/…‎/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
petsto‎re/java‎
apache-httpclient/‎src/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
feign-no-nullable/‎src/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
feign/src/main/…/…/‎openapitools/client‎
ServerConfig‎uration.java‎ +1 -1
google-api-client/‎src/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
jersey1/src/…/…/…/‎openapitools/client‎
ServerConfig‎uration.java‎ +1 -1
jersey2-java8-local‎datetime/…/…/…/…/…/…‎
ServerConfig‎uration.java‎ +1 -1
jersey2-java8/sr‎c/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
native-async/sr‎c/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
native/src/main/…/…‎/openapitools/client‎
ServerConfig‎uration.java‎ +1 -1
okhttp-gson-parcela‎bleModel/…/…/…/…/…/…‎
ServerConfig‎uration.java‎ +1 -1
okhttp-gson/src‎/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
rest-assured-jackso‎n/src/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
rest-assured/sr‎c/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
resteasy/src/…/…/…/‎openapitools/client‎
ServerConfig‎uration.java‎ +1 -1
resttemplate-withXm‎l/src/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
resttemplate/sr‎c/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
retrofit2-play26/‎src/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
retrofit2/src/…/…/…‎/openapitools/client‎
ServerConfig‎uration.java‎ +1 -1
retrofit2rx2/sr‎c/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
retrofit2rx3/sr‎c/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
vertx-no-nullable/‎src/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
vertx/src/main/…/…/‎openapitools/client‎
ServerConfig‎uration.java‎ +1 -1
webclient-nulable-‎arrays/…/…/…/…/…/…‎
ServerConfig‎uration.java‎ +1 -1
webclient/src/…/…/…‎/openapitools/client‎
ServerConfig‎uration.java‎ +1 -1
…/…/…/‎…/…/…/…‎
ServerConfig‎uration.java‎ +1 -1
openapi‎3/client‎
extensions/…/…/…‎/…/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
petsto‎re/java‎
jersey2-java8/sr‎c/…/…/…/…/client‎
ServerConfig‎uration.java‎ +1 -1
…/…/…/‎…/…/…/…‎
ServerConfig‎uration.java‎ +1 -1
modules/openapi-generator/src/main/resources/Java/ServerConfiguration.mustache
+ 1
- 1
  • View file @ c36fe58b

  • Edit in single-file editor

  • Open in Web IDE


@@ -39,7 +39,7 @@ public class ServerConfiguration {
if (variables != null && variables.containsKey(name)) {
value = variables.get(name);
if (serverVariable.enumValues.size() > 0 && !serverVariable.enumValues.contains(value)) {
throw new RuntimeException("The variable " + name + " in the server URL has invalid value " + value + ".");
throw new IllegalArgumentException("The variable " + name + " in the server URL has invalid value " + value + ".");
}
}
url = url.replaceAll("\\{" + name + "\\}", value);
samples/client/others/java/okhttp-gson-streaming/src/main/java/org/openapitools/client/ServerConfiguration.java
+ 1
- 1
  • View file @ c36fe58b

  • Edit in single-file editor

  • Open in Web IDE


@@ -39,7 +39,7 @@ public class ServerConfiguration {
if (variables != null && variables.containsKey(name)) {
value = variables.get(name);
if (serverVariable.enumValues.size() > 0 && !serverVariable.enumValues.contains(value)) {
throw new RuntimeException("The variable " + name + " in the server URL has invalid value " + value + ".");
throw new IllegalArgumentException("The variable " + name + " in the server URL has invalid value " + value + ".");
}
}
url = url.replaceAll("\\{" + name + "\\}", value);
samples/client/petstore/java/apache-httpclient/src/main/java/org/openapitools/client/ServerConfiguration.java
+ 1
- 1
  • View file @ c36fe58b

  • Edit in single-file editor

  • Open in Web IDE


@@ -39,7 +39,7 @@ public class ServerConfiguration {
if (variables != null && variables.containsKey(name)) {
value = variables.get(name);
if (serverVariable.enumValues.size() > 0 && !serverVariable.enumValues.contains(value)) {
throw new RuntimeException("The variable " + name + " in the server URL has invalid value " + value + ".");
throw new IllegalArgumentException("The variable " + name + " in the server URL has invalid value " + value + ".");
}
}
url = url.replaceAll("\\{" + name + "\\}", value);
samples/client/petstore/java/feign/src/main/java/org/openapitools/client/ServerConfiguration.java
+ 1
- 1
  • View file @ c36fe58b

  • Edit in single-file editor

  • Open in Web IDE


@@ -39,7 +39,7 @@ public class ServerConfiguration {
if (variables != null && variables.containsKey(name)) {
value = variables.get(name);
if (serverVariable.enumValues.size() > 0 && !serverVariable.enumValues.contains(value)) {
throw new RuntimeException("The variable " + name + " in the server URL has invalid value " + value + ".");
throw new IllegalArgumentException("The variable " + name + " in the server URL has invalid value " + value + ".");
}
}
url = url.replaceAll("\\{" + name + "\\}", value);
samples/client/petstore/java/feign-no-nullable/src/main/java/org/openapitools/client/ServerConfiguration.java
+ 1
- 1
  • View file @ c36fe58b

  • Edit in single-file editor

  • Open in Web IDE


@@ -39,7 +39,7 @@ public class ServerConfiguration {
if (variables != null && variables.containsKey(name)) {
value = variables.get(name);
if (serverVariable.enumValues.size() > 0 && !serverVariable.enumValues.contains(value)) {
throw new RuntimeException("The variable " + name + " in the server URL has invalid value " + value + ".");
throw new IllegalArgumentException("The variable " + name + " in the server URL has invalid value " + value + ".");
}
}
url = url.replaceAll("\\{" + name + "\\}", value);
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: Go Enhancement: General
2
Client: Go Enhancement: General
    Assign labels
  • Manage project labels

Milestone
4.3.0
4.3.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: OpenAPITools/openapi-generator!5150
Source branch: jersey2-exception

Menu

Explore Projects Groups Snippets