Skip to content
GitLab

[C#] Fix issue #1088 with generation of enum classes referenced from other objects

Merged Administrator requested to merge github/fork/rubms/Fix_issue_#1088 into master

Created by: rubms

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixed the https://github.com/OpenAPITools/openapi-generator/issues/1088 issue. As explained in the suggestion in the issue description, I removed the update of enum properties, in AbstractCSharpCodeGen.java, for enums referenced from other objects in the OpenAPI specification. The removed update was incorrectly setting the isString properties of enum values to false, resulting in an incorrect generation of the enum class, while it is apparently providing no benefit at all.

c.c. C# technical committee: @mandrean (2017/08) @jimschubert (2017/09)