Skip to content
GitLab

[PythonClientCodeGen] Generated model for not inheriting attributes from parent

Closed Administrator requested to merge github/fork/narenandu/python_client_inheritence_model_properties into master

Created by: narenandu

CC'ing technical committee: @taxpon @frol @mbohlool @cbornet @kenjones-cisco to review the pull request if your PR is targeting python programming language.

Description of the PR

It is kind of counter intuitive, but setting supportsInheritance = true is failing to get the properties from the parent when a child model inherits. Didn't dive deep in to the actual base class for the code generation, but commenting out the line from PythonClientCodegen.java fixed the issue.

This solves the reported issues

There could be multiple reasons since I didn't go to the root cause

  • First that there is no AbstractPyCodegen.java, which might/might not tackle the issue
  • Second, we don't know if other code gen for languages like ObjcClientCodegen / PhpClientCodegen are working since, they also are using supportsInheritence = true in their generation code