Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !11003

[php] Only use values up to the second accuracy for PHP datetime values

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/launchdarkly/cquan/fix-php-precision into master 3 years ago
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 2

Created by: carmenquan

https://github.com/OpenAPITools/openapi-generator/issues/10548

Description PHP is unable to handle highly precise DateTime Values. While this issue covered most cases, we have a few instances of DateTime which are not handled. (i.e. "2021-10-06T20:17:16.076372256Z")

Example:

print_r(strtotime("2021-10-06T20:17:16.076372256Z")); // => ""
print_r(strtotime("2021-10-06T20:17:16.07637225Z")); // =>  "1633551436"

To fix this we only use up to the second accuracy by trimming the date string. strtotime is only accurate up to number of seconds so this does not result in data loss. https://www.php.net/manual/en/function.strtotime.php

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Approval is optional

Closed by (Jul 27, 2025 8:32pm UTC)

Merge details

  • The changes were not merged into master.

Activity


  • William Cheng added Client: PHP Issue: Bug labels 3 years ago

    added Client: PHP Issue: Bug labels

  • Administrator requested review from @root 3 years ago

    requested review from @root

  • Administrator changed title from Only use values up to the second accuracy for PHP datetime values to [php] Only use values up to the second accuracy for PHP datetime values 3 years ago

    changed title from Only use values up to the second accuracy for PHP datetime values to [php] Only use values up to the second accuracy for PHP datetime values

  • Administrator mentioned in merge request !11213 (merged) 3 years ago

    mentioned in merge request !11213 (merged)

  • Administrator closed 3 years ago

    closed

  • Administrator removed review request for @root 3 years ago

    removed review request for @root

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: PHP Issue: Bug
2
Client: PHP Issue: Bug
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: OpenAPITools/openapi-generator!11003
Source branch: github/fork/launchdarkly/cquan/fix-php-precision

Menu

Explore Projects Groups Snippets