Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !11031

java-typemapping-defaults - breaking test demonstrating issue where t…

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/randeepbydesign/java-typemapping-defaults into master 3 years ago
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Created by: randeepbydesign

demonstrating issue where type mappings are not taken into account when showing the default value. See https://github.com/OpenAPITools/openapi-generator/issues/11029

I would have included the proposed fix along with this PR but it isn't working for me.

  • Modified getDefaultValue() to call getSchemaType()
  • Was hoping this would return the Long type, but it returns ModelLong with a warning. It looks like there is some redundancy in the use of typeMappings as AbstractJavaCodegen.getSchemaType calls the DefaultCodegen.getSchemaType and both use typemappings which interferes with the attempt to return a value before calling toModelName

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Pipeline #592 failed for d83eab56 on github/fork/randeepbydesign/java-typemapping-defaults 2 years ago
Approval is optional
Merge blocked: merge conflicts must be resolved. Users who can write to the source or target branches can resolve the conflicts.

Merge details

  • The source branch is 1915 commits behind the target branch
  • 1 commit and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity


  • Administrator mentioned in issue #11029 3 years ago

    mentioned in issue #11029

  • Administrator restored source branch github/fork/randeepbydesign/java-typemapping-defaults 2 years ago

    restored source branch github/fork/randeepbydesign/java-typemapping-defaults

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: OpenAPITools/openapi-generator!11031
Source branch: github/fork/randeepbydesign/java-typemapping-defaults

Menu

Explore Projects Groups Snippets