Skip to content
GitLab

[elm] Major refactoring; add discriminator support

Merged Administrator requested to merge github/fork/eriktim/elm-discriminator into master

Created by: eriktim

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

@wing328 Sorry this PR has become rather large.

  • Use the same name for all exposed encoder & decoders
    --> module Cat exposing (Cat, catDecoder, catEncoder) now becomes module Cat exposing (Cat, decoder, encoder);
  • Improve imports (limit exposures)
    --> import Data.Cat exposing (Cat, catDecoder, catEncoder) now becomes import Data.Cat as Cat exposing (Cat), and hence Cat.decoder is used instead of catDecoder;
  • Add support for OAS3 discriminators
    --> You can now use discriminators to make custom types like Pet = CatType Cat | DogType Dog;
  • Distinct between 0.18 & latest mustache files.