Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !11135

useSingleRequestParameter should mark parameter optional if all properties are optional

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/davidgamero/davidgamero/node-fetch-single-param-optional into master 3 years ago
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: davidgamero

This PR uses a default value to requestParameters (= {}) if all the parameters are optional.

Fixes #11112 (closed)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov

Compare
  • master (base)

and
  • latest version
    0bdac600
    2 commits, 2 years ago

3 files
+ 10
- 10

    Preferences

    File browser
    Compare changes
modules/…/…/…/…/‎typescript-fetch‎
apis.m‎ustache‎ +1 -1
samples/clie‎nt/…/…/builds‎
default-‎v3.0/apis‎
FakeA‎pi.ts‎ +5 -5
enum‎/apis‎
Defaul‎tApi.ts‎ +4 -4
modules/openapi-generator/src/main/resources/typescript-fetch/apis.mustache
+ 1
- 1
  • View file @ 0bdac600

  • Edit in single-file editor

  • Open in Web IDE


@@ -342,7 +342,7 @@ export class {{classname}} extends runtime.BaseAPI {
}
{{/useSingleRequestParameter}}
{{#useSingleRequestParameter}}
async {{nickname}}({{#allParams.0}}requestParameters: {{#prefixParameterInterfaces}}{{classname}}{{/prefixParameterInterfaces}}{{operationIdCamelCase}}Request, {{/allParams.0}}initOverrides?: RequestInit): Promise<{{{returnType}}}{{^returnType}}void{{/returnType}}> {
async {{nickname}}({{#allParams.0}}requestParameters: {{#prefixParameterInterfaces}}{{classname}}{{/prefixParameterInterfaces}}{{operationIdCamelCase}}Request{{^hasRequiredParams}} = {}{{/hasRequiredParams}}, {{/allParams.0}}initOverrides?: RequestInit): Promise<{{{returnType}}}{{^returnType}}void{{/returnType}}> {
{{#returnType}}
const response = await this.{{nickname}}Raw({{#allParams.0}}requestParameters, {{/allParams.0}}initOverrides);
return await response.value();
samples/client/petstore/typescript-fetch/builds/default-v3.0/apis/FakeApi.ts
+ 5
- 5
  • View file @ 0bdac600

  • Edit in single-file editor

  • Open in Web IDE


@@ -232,7 +232,7 @@ export class FakeApi extends runtime.BaseAPI {
/**
* Test serialization of outer boolean types
*/
async fakeOuterBooleanSerialize(requestParameters: FakeOuterBooleanSerializeRequest, initOverrides?: RequestInit): Promise<boolean> {
async fakeOuterBooleanSerialize(requestParameters: FakeOuterBooleanSerializeRequest = {}, initOverrides?: RequestInit): Promise<boolean> {
const response = await this.fakeOuterBooleanSerializeRaw(requestParameters, initOverrides);
return await response.value();
}
@@ -261,7 +261,7 @@ export class FakeApi extends runtime.BaseAPI {
/**
* Test serialization of object with outer number type
*/
async fakeOuterCompositeSerialize(requestParameters: FakeOuterCompositeSerializeRequest, initOverrides?: RequestInit): Promise<OuterComposite> {
async fakeOuterCompositeSerialize(requestParameters: FakeOuterCompositeSerializeRequest = {}, initOverrides?: RequestInit): Promise<OuterComposite> {
const response = await this.fakeOuterCompositeSerializeRaw(requestParameters, initOverrides);
return await response.value();
}
@@ -290,7 +290,7 @@ export class FakeApi extends runtime.BaseAPI {
/**
* Test serialization of outer number types
*/
async fakeOuterNumberSerialize(requestParameters: FakeOuterNumberSerializeRequest, initOverrides?: RequestInit): Promise<number> {
async fakeOuterNumberSerialize(requestParameters: FakeOuterNumberSerializeRequest = {}, initOverrides?: RequestInit): Promise<number> {
const response = await this.fakeOuterNumberSerializeRaw(requestParameters, initOverrides);
return await response.value();
}
@@ -319,7 +319,7 @@ export class FakeApi extends runtime.BaseAPI {
/**
* Test serialization of outer string types
*/
async fakeOuterStringSerialize(requestParameters: FakeOuterStringSerializeRequest, initOverrides?: RequestInit): Promise<string> {
async fakeOuterStringSerialize(requestParameters: FakeOuterStringSerializeRequest = {}, initOverrides?: RequestInit): Promise<string> {
const response = await this.fakeOuterStringSerializeRaw(requestParameters, initOverrides);
return await response.value();
}
@@ -683,7 +683,7 @@ export class FakeApi extends runtime.BaseAPI {
* To test enum parameters
* To test enum parameters
*/
async testEnumParameters(requestParameters: TestEnumParametersRequest, initOverrides?: RequestInit): Promise<void> {
async testEnumParameters(requestParameters: TestEnumParametersRequest = {}, initOverrides?: RequestInit): Promise<void> {
await this.testEnumParametersRaw(requestParameters, initOverrides);
}
samples/client/petstore/typescript-fetch/builds/enum/apis/DefaultApi.ts
+ 4
- 4
  • View file @ 0bdac600

  • Edit in single-file editor

  • Open in Web IDE


@@ -94,7 +94,7 @@ export class DefaultApi extends runtime.BaseAPI {
/**
*/
async fakeEnumRequestGetInline(requestParameters: FakeEnumRequestGetInlineRequest, initOverrides?: RequestInit): Promise<InlineResponse200> {
async fakeEnumRequestGetInline(requestParameters: FakeEnumRequestGetInlineRequest = {}, initOverrides?: RequestInit): Promise<InlineResponse200> {
const response = await this.fakeEnumRequestGetInlineRaw(requestParameters, initOverrides);
return await response.value();
}
@@ -134,7 +134,7 @@ export class DefaultApi extends runtime.BaseAPI {
/**
*/
async fakeEnumRequestGetRef(requestParameters: FakeEnumRequestGetRefRequest, initOverrides?: RequestInit): Promise<EnumPatternObject> {
async fakeEnumRequestGetRef(requestParameters: FakeEnumRequestGetRefRequest = {}, initOverrides?: RequestInit): Promise<EnumPatternObject> {
const response = await this.fakeEnumRequestGetRefRaw(requestParameters, initOverrides);
return await response.value();
}
@@ -161,7 +161,7 @@ export class DefaultApi extends runtime.BaseAPI {
/**
*/
async fakeEnumRequestPostInline(requestParameters: FakeEnumRequestPostInlineRequest, initOverrides?: RequestInit): Promise<InlineObject> {
async fakeEnumRequestPostInline(requestParameters: FakeEnumRequestPostInlineRequest = {}, initOverrides?: RequestInit): Promise<InlineObject> {
const response = await this.fakeEnumRequestPostInlineRaw(requestParameters, initOverrides);
return await response.value();
}
@@ -188,7 +188,7 @@ export class DefaultApi extends runtime.BaseAPI {
/**
*/
async fakeEnumRequestPostRef(requestParameters: FakeEnumRequestPostRefRequest, initOverrides?: RequestInit): Promise<EnumPatternObject> {
async fakeEnumRequestPostRef(requestParameters: FakeEnumRequestPostRefRequest = {}, initOverrides?: RequestInit): Promise<EnumPatternObject> {
const response = await this.fakeEnumRequestPostRefRaw(requestParameters, initOverrides);
return await response.value();
}
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
Client: TypeScript
1
Client: TypeScript
    Assign labels
  • Manage project labels

Milestone
5.3.1
5.3.1 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: OpenAPITools/openapi-generator!11135
Source branch: github/fork/davidgamero/davidgamero/node-fetch-single-param-optional

Menu

Explore Projects Groups Snippets