Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !1127

[C#] Fixed invalid generation of C# children models in allOf clauses

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/rubms/Fix_issue_#1126 into master Sep 27, 2018
  • Overview 0
  • Commits 6
  • Pipelines 0
  • Changes 4

Created by: rubms

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixed the #1126 (closed) issue, that causes the auto-generated C# children models not to compile because they attempt to invoke a BaseValidate method in the parent model that is not implemented. In order to fix the issue:

  • DefaultCodegen.java now sets the hasChildren of CodegenModel to true in models that have children.
  • The modelGeneric.mustache now uses hasChildren, instead of discriminator, in order to decide whether to implement a BaseValidate method (for children to run the parent model validations). In addition, now the BaseValidate method of the parent is explicitly invoked (in order to prevent infinite recursion in models that are both, children and parents.

c.c. Core (as DefaultCodegen.java has been modified). @wing328 (2015/07) @jimschubert (2016/05) @cbornet (2016/05) @jaz-ah (2016/05) @ackintosh (2018/02) @JFCote (2018/03) @jmini (2018/04)

c.c. C# @mandrean (2017/08) @jimschubert (2017/09)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rubms/Fix_issue_#1126