Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !11272

[csharp-netcore] Fix: Add only first Authorization header

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Anakael/pr/anakael/fix-csharp-core-duplicate-headers into master 3 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 12

Created by: Anakael

This PR fix problem in csharp-netcore client with invalid(multiple) authorization header if more than one security present in spec file.

Steps to reproduce:

  1. Create new C# web project with bearer auth scheme which consumes access_token and put Authorize attribute on test controller
  2. Install Swashbuckle to project
  3. Add Bearer and OAuth schemes to swagger via AddSecurityRequirement
  4. Generate csharp-netcore client against spec
  5. Put AccessToken in Configuration for generated client
  6. Call request on generated client <-- 401 here

Solution:

Pass only one Authorization header. Which one will be chosen from first met scheme.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Approval is optional

Merged by (Jul 27, 2025 7:20pm UTC)

Merge details

  • Changes merged into master with ca46fd80.
  • Deleted the source branch.

Activity


  • William Cheng added Client: C-Sharp Issue: Bug labels 3 years ago

    added Client: C-Sharp Issue: Bug labels

  • William Cheng changed milestone to %5.4.0 3 years ago

    changed milestone to %5.4.0

  • William Cheng closed 3 years ago

    closed

  • Administrator mentioned in issue #11271 3 years ago

    mentioned in issue #11271

  • Administrator mentioned in merge request !11325 (merged) 3 years ago

    mentioned in merge request !11325 (merged)

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: C-Sharp Issue: Bug
2
Client: C-Sharp Issue: Bug
    Assign labels
  • Manage project labels

Milestone
5.4.0
5.4.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: OpenAPITools/openapi-generator!11272
Source branch: github/fork/Anakael/pr/anakael/fix-csharp-core-duplicate-headers

Menu

Explore Projects Groups Snippets