Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !11486

[PHP] Fix checking value of `Configuration::getAccessToken()`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jtreminio/basicauth-oauth into master 3 years ago
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: jtreminio

Configuration::getAccessToken() returns an empty string, but API classes currently do a null check:

if ($this->config->getAccessToken() !== null)

This will always be true whenever an endpoint allows access token auth.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Approval is optional

Merged by (Jul 27, 2025 3:11pm UTC)

Merge details

  • Changes merged into master with eb5d1081.
  • Deleted the source branch.

Activity


  • Administrator changed title from Basicauth oauth to {+[PHP] Fix checking value of Configuration::getAccessToken()+} 3 years ago

    changed title from Basicauth oauth to {+[PHP] Fix checking value of Configuration::getAccessToken()+}

  • Administrator added Client: PHP Feature: Authentication Issue: Bug labels 3 years ago

    added Client: PHP Feature: Authentication Issue: Bug labels

  • Administrator requested review from @root 3 years ago

    requested review from @root

  • Administrator closed 3 years ago

    closed

  • William Cheng changed milestone to %6.0.0 3 years ago

    changed milestone to %6.0.0

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
3
Client: PHP Feature: Authentication Issue: Bug
3
Client: PHP Feature: Authentication Issue: Bug
    Assign labels
  • Manage project labels

Milestone
6.0.0
6.0.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: OpenAPITools/openapi-generator!11486
Source branch: github/fork/jtreminio/basicauth-oauth

Menu

Explore Projects Groups Snippets