Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !1157

FIX: remove special quotation marks from filename generation.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/smasala/issue-1137-fix into master Oct 02, 2018
  • Overview 0
  • Commits 7
  • Pipelines 0
  • Changes 2

Created by: smasala

Developed with @tropan

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master (3.3.x), 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09)

Description of the PR

Generics are given double left and right pointing quotation marks in the JSON declaration file:

MyModel«Set«AnotherType»»

Although the API in (TypeScript) imports the models correctly:

import { MyModel } from '../models/myModelSetAnotherType'

The filename itself still has the special punctuation marks:

myModel«Set«AnotherType»».ts

This pull request simply removes the special characters from the filename before creation by cleaning the filename string accordingly.

myModel«Set«AnotherType»».ts => myModelSetAnotherType.ts

Original Issue: https://github.com/OpenAPITools/openapi-generator/issues/1137

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/smasala/issue-1137-fix