Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !11602

[php] fixed model_enum.mustache for real usage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/77web/patch-1 into master 3 years ago
  • Overview 0
  • Commits 6
  • Pipelines 1
  • Changes 9

Created by: 77web

fixed Enum usage in PHP APIClients. I tested actual API requests with this new EnumInterface, which performs API requests successfully :smile:

before

// code which causes error in static analysis
$someModel = new SomeModel();
$someModel->setSomeEnumField(SomeEnum::VALUE_A); // error, setter has type declaration in phpdoc with "SomeEnum" , SomeEnum::VALUE_A is not a "SomeEnum" instance, but just a string in php

// code to avoid error
$someModel = new SomeModel([
    'some_enum_field' => SomeEnum::VALUE_A,
]);

after

$someModel = new SomeModel();
$someModel->setSomeEnumField(new SomeEnum(SomeEnum::VALUE_A));

note: php8.1 has native Enum feature and it allows code like this.

$someModel = new SomeModel();
$someModel->setSomeEnumField(SomeEnum::VALUE_A);

But, many projects have not yet updated their environments to php8.1.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Activity

  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Status
Pipeline
Triggerer
Stages
Actions

2 years ago

updated samples
#607
github/fork/77web/patch-1 1119d574
latest Auto DevOps
avatar
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
3
Client: C-Sharp Enhancement: CI/Test Server: C-Sharp
3
Client: C-Sharp Enhancement: CI/Test Server: C-Sharp
    Assign labels
  • Manage project labels

Milestone
3.3.1
3.3.1 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: OpenAPITools/openapi-generator!1238
Source branch: github/fork/77web/patch-1

Menu

Explore Projects Groups Snippets