Skip to content
GitLab

9904 Fix double quoting default values in Kotlin Spring

Merged Administrator requested to merge github/fork/bamapookie/9904_fix_double_quoting_default_values into master

Created by: bamapookie

Fix for #9904.

Kotlin files with default values that are not enums were getting double quoted (defaultValue = ""default"") in API file generation. This fixes the issue for query parameters.

The first commit adds a method to the petstore sample that uses the code path demonstrating this bug. See the second commit for the invalid source generated. (kotlin-springboot)

CC: Kotlin committee members @jimschubert, @dr4ke616, @karismann, @Zomzog, @andrewemery, @4brunu, and @yutaka0m

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Fix should go into 5.4.0 branch as well.