Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !11750

[ruby] Allow boolean for discriminator value in oneOf handling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ykitamura-mdsol/ruby_boolean_discriminator_value into master Feb 28, 2022
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: ykitamura-mdsol

This must be a very rare case but we are using a boolean property as discriminator:

    CarOrCustomCar:
      oneOf:
        - $ref: '#/components/schemas/Car'
        - $ref: '#/components/schemas/CustomCar'
      discriminator:
        propertyName: custom_flag
        mapping:
          true: '#/components/schemas/CustomCar'
          false: '#/components/schemas/Car'

    CustomCar:
      properties:
         :
        custom_flag:
          type: boolean

    Car:
      properties:
         :
        custom_flag:
          type: boolean

The OpenAPI specification says:

Mapping keys MUST be string values, but tooling MAY convert response values to strings for comparison.

So I think we can modify to handle boolean values property for discriminator.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ykitamura-mdsol/ruby_boolean_discriminator_value