Skip to content
GitLab

[Cpp][Qt][Client] Fix CMakeLists.txt, Qt::Gui, Find_Package(OpenSSL)

Merged Administrator requested to merge github/fork/Thaulino/Cpp]-Qt]-Fix-CmakeList.txt-qt-Gui-FindPackage(OpenSSL) into master

Created by: Thaulino

Note replacement of : #11950

Description

Changed: Always add Qt5::Gui to build, needed because {{prefix}}Oauth.h is always part of the build Added: find_package for OpenSSL, should be done prior target_link_libraries

Tests that have been done :

(ubuntu) install deps (reference #11371 (closed) ): sudo apt install -y --no-install-recommends qt5-default run code generator: java -jar openapi-generator-cli-5.4.0.jar generate -t cpp-qt-templates -i petstore.json -g cpp-qt-client -o petstore run cmake: cmake -S petstore -B petstore/build

(windows) run code generator: java -jar openapi-generator-cli-5.4.0.jar generate -t cpp-qt-templates -i petstore.json -g cpp-qt-client -o petstore run cmake: cmake -S petstore -B petstore/build

Issue

fixes #11371 (closed)

technical commitee

@wing328 cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.