Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !11987

Fixed java/spring oneOf generator (Inline oneOf support) #11932

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/wagnerrobsan/java-oneOf-gen-model-bug into master Mar 28, 2022
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: wagnerrobsan

Fixes #11932 (closed)

When generating a spring or java code with a spec that contains an attribute with an inline oneOf, the code generator creates a code with a bug.

Currently, before the code generation, the DefaultGenerator validates the schema type, if the schema is an object, it calls the default setTypeProperties method in the IJsonSchemaValidationProperties interface to validate the schema. If the schema is an object, the CodegenModel isMap attribute is set to true, which incorrectly creates the code with an additional method for Map structures.

This simple change modifies the Schema type from object to the OneOf interface created to support the provided sub-subschemas.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/wagnerrobsan/java-oneOf-gen-model-bug