Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12101
An error occurred while fetching the assigned milestone of the selected merge_request.

[typescript-fetch] Removed functions that are unused when withoutRuntime is true.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/mkusaka/improve-without-runtime-check-format into master 3 years ago
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: mkusaka

Changed to remove the exist and mapValue functions from runtime.ts when withoutRuntimeChecks is true.

This is because these functions are not used when this option is true.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03)

Compare
  • master (base)

and
  • latest version
    a2dc7db5
    2 commits, 2 years ago

2 files
+ 4
- 10

    Preferences

    File browser
    Compare changes
modules/…/…/…/…/‎typescript-fetch‎
runtime.‎mustache‎ +4 -0
samples/clien‎t/…/…/…/…/src‎
runti‎me.ts‎ +0 -10
modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache
+ 4
- 0
  • View file @ a2dc7db5

  • Edit in single-file editor

  • Open in Web IDE


@@ -211,10 +211,12 @@ export interface RequestOpts {
body?: HTTPBody;
}
{{^withoutRuntimeChecks}}
export function exists(json: any, key: string) {
const value = json[key];
return value !== null && value !== undefined;
}
{{/withoutRuntimeChecks}}
export function querystring(params: HTTPQuery, prefix: string = ''): string {
return Object.keys(params)
@@ -238,12 +240,14 @@ export function querystring(params: HTTPQuery, prefix: string = ''): string {
.join('&');
}
{{^withoutRuntimeChecks}}
export function mapValues(data: any, fn: (item: any) => any) {
return Object.keys(data).reduce(
(acc, key) => ({ ...acc, [key]: fn(data[key]) }),
{}
);
}
{{/withoutRuntimeChecks}}
export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
samples/client/petstore/typescript-fetch/builds/without-runtime-checks/src/runtime.ts
+ 0
- 10
  • View file @ a2dc7db5

  • Edit in single-file editor

  • Open in Web IDE


@@ -222,10 +222,6 @@ export interface RequestOpts {
body?: HTTPBody;
}
export function exists(json: any, key: string) {
const value = json[key];
return value !== null && value !== undefined;
}
export function querystring(params: HTTPQuery, prefix: string = ''): string {
return Object.keys(params)
@@ -249,12 +245,6 @@ export function querystring(params: HTTPQuery, prefix: string = ''): string {
.join('&');
}
export function mapValues(data: any, fn: (item: any) => any) {
return Object.keys(data).reduce(
(acc, key) => ({ ...acc, [key]: fn(data[key]) }),
{}
);
}
export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/mkusaka/improve-without-runtime-check-format

Menu

Explore Projects Groups Snippets