Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12102

[typescript-fetch] drop support typescript under v4.0

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/mkusaka/drop-support-lower-typescript-version into master Apr 10, 2022
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 98

Created by: mkusaka

This PR is intended to serve as a basis for discussion.

I would like to drop support for typescript versions below 4.0 for the following reasons.

  • Typescript have released lots of improvements since current supported version: 2.x, 3.x.
    • https://devblogs.microsoft.com/typescript/
  • Typescript version 4.0 has been released at 2 years ago, and most users use 4.0 or above
    • see: https://www.npmjs.com/package/typescript -> versions tab.
  • Some new implementation for typescirpt-fetch falling test due to lower typescript version... and we have to additional implementation for that.
    • for example: ce994a6 (#11976), 1921df7 (#12098)
  • Currently, openapi-generator prepare for 6.0. So, this is good time to introduce this breaking changes.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03)

Hi 👋 I would like to know the opinion of the maintainer.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mkusaka/drop-support-lower-typescript-version